fix(agent): keep public-safe packets free of private evidence - #892

💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

Superagent didn't find any vulnerabilities or security issues in this PR.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.71%. Comparing base (5d9d73a) to head (5dd80b7).

@@           Coverage Diff           @@
##             main     #892   +/-   ##
=======================================
  Coverage   96.71%   96.71%           
=======================================
  Files         108      108           
  Lines       14641    14643    +2     
  Branches     5298     5299    +1     
=======================================
+ Hits        14160    14162    +2     
  Misses        102      102           
  Partials      379      379           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

gittensory · advisory review

Reviewed 2 changed file(s) — two independent AI reviewers.

Changed files: src/services/agent-orchestrator.ts, test/unit/agent-orchestrator.test.ts

Suggested action: ✅ Safe to merge — both reviewers found no blocking issues.

Reviewer A · gpt-oss-120b — recommends ✅ merge
The PR updates the agent orchestrator to omit private recommendation evidence from payloads when the safety class is "public_safe", aligning with the public/private boundary policy. Tests are added to verify the omission and ensure no private strings leak.

Suggestions

• Add a unit test confirming that when safetyClass is not "public_safe" (e.g., "private"), the recommendationEvidence field is included as expected.
• Verify that downstream consumers of the payload gracefully handle the absence of recommendationEvidence for public_safe actions.

Worth double-checking

• Potential downstream code assuming recommendationEvidence always exists may encounter undefined; ensure it tolerates missing field.
• Make sure the default safetyClass handling remains consistent across all callers.

Reviewer B · nemotron-3-120b-a12b — recommends ✅ merge
The PR modifies actionRecord to conditionally include recommendationEvidence only when safetyClass is not 'public_safe', ensuring public-safe packets do not contain private evidence. Tests are added to verify this behavior for the prepare_pr_packet action. The change correctly enforces the public/private boundary invariant.

Suggestions

• Consider explicitly deleting recommendationEvidence from payload for public_safe safetyClass to guard against accidental inclusion via args.payload.
• Add a comment explaining the guard to aid future maintainers.
• If other public_safe action types exist, add test coverage for them to ensure consistent behavior.

Worth double-checking

• If a caller mistakenly includes recommendationEvidence in args.payload for a public_safe action, it would not be stripped and could leak private info.
• Ensure no other payload fields inadvertently contain private evidence for public_safe actions.